Refactored notifications handling

Charcoal-SE / PulseMonitor

PulseMonitor is the chat interface to Halflife.

MIT License

4 stars 3 forks source link

Refactored notifications handling #29

Closed mjpieters closed 4 years ago

mjpieters commented 4 years ago

This is rather a big refactor of the notifications storage and commands, to

eliminate bugs with pattern removing
ensuring thread-safety (there was none)
improved unnotify handling (patterns are matched both on equality and on regex matching)

I've included a test suite to help keep this part in working order.

tripleee commented 4 years ago

Thanks, this is looking excellent! I'm not in a place where I can easily play around with this so I will probably be sitting on it for a few days. Please don't hesitate to remind me with a ping if I don't get this merged and deployed during next week.

mjpieters commented 4 years ago

@tripleee not a problem!

I started this because I wanted to fix the constant ValueError exceptions I saw when trying to use unnotify and got a bit carried away there.

One thing I see I forgot to mention: I updated the usage() methods for notify and unnotify from ... to * ...; they both take 1 or more arguments, not zero or more.

I've also added a simple github actions workflow to run the tests every time a commit is made to the master branch, or if a pull request against the same is made.

tripleee commented 4 years ago

Thanks! Deployed now.

https://chat.stackexchange.com/transcript/message/54307170#54307170