search

Charcoal-SE / SmokeDetector

Headless chatbot that detects spam and posts links to it in chatrooms for quick deletion.
https://metasmoke.erwaysoftware.com
Apache License 2.0
467 stars 181 forks source link

improve a number matcher in watched keywords #13135

Closed micsthepick closed 6 days ago

micsthepick commented 1 week ago

don't match an ipv6 format, make sure we only start matching on the first digit.

micsthepick commented 1 week ago

some more info - I expect this to cause at least one less FP, and it should not remove any TP. If it does then I'll review

micsthepick commented 1 week ago

Metrics: Before: TP: 1067 FP: 8 NAA: 0 After: TP: 1067 FP: 7 NAA: 0

micsthepick commented 1 week ago

(waffles) - the above was me getting confused as to whether to rebase on origin/master or upstream/master and then deciding to fix up the commit msg.

makyen commented 6 days ago

I'm confused. This says that it's "improve a number matcher", which implies that it's changing something, but the change to the watchlist is to only add an entry. Was something already removed somewhere else?

micsthepick commented 6 days ago

Seems to have gotten lost in the rebasing, will check this @makyen

micsthepick commented 6 days ago

actually, this may have been something that I noticed for two reasons, it looks like one of the migrations to watched_numbers makes this PR redundant

micsthepick commented 6 days ago

relevant info: #13187