search

Charcoal-SE / SmokeDetector

Headless chatbot that detects spam and posts links to it in chatrooms for quick deletion.
https://metasmoke.erwaysoftware.com
Apache License 2.0
474 stars 182 forks source link

Still no MS link in long chat messages #1737

Closed tripleee closed 6 years ago

tripleee commented 6 years ago

488 was closed last year but the logic in shortening chat messages still sometimes removes the MS link. This seems to annoy and baffle people, probably more than dropping a few more reasons would.

Chat: https://chat.stackexchange.com/transcript/message/43397950#43397950

M-A-Ramezani commented 6 years ago

I'm not ever interested in seeing the fourth and fifth reasons. No one is. Two or three reasons, preferably ones with the highest weight, should be enough.

j-f1 commented 6 years ago

Looks like we explicitly remove the MS link, and the wheel of blame points to @quartata.

https://github.com/Charcoal-SE/SmokeDetector/blob/b369a9808ce0fd43f58bc839369dca56c968c66b/spamhandling.py#L133-L135

quartata commented 6 years ago

@j-f1 I was just the last person to touch that line (I've touched every line in that file pretty much). It's always worked like that.

angussidney commented 6 years ago

@j-f1 that specific code has been the same since Metasmoke was introduced - I was the last person to make meaningful changes to that logic, and that was to limit it to 5 reasons