Charcoal-SE / SmokeDetector

Headless chatbot that detects spam and posts links to it in chatrooms for quick deletion.
https://metasmoke.erwaysoftware.com
Apache License 2.0
474 stars 182 forks source link

Exclude goo.gl/forms and goo.gl/maps from the short URL check #3720

Closed gparyani closed 4 years ago

gparyani commented 4 years ago

Yes, goo.gl is a URL shortener, and yes, I'm aware that it's been discontinued. I don't disagree that it should remain on the watchlist since old links still continue to work.

However, since (and before) its discontinuation, it has been repurposed to provide internal Google link shortcuts, e.g. goo.gl/maps/... and goo.gl/forms/....

Can these, as well as any other legitimate Google-internal short URL schemes, please be removed from the short URL check?

stale[bot] commented 4 years ago

This issue has been closed because it has had no recent activity. If this is still important, please add another comment and find someone with write permissions to reopen the issue. Thank you for your contributions.

tripleee commented 4 years ago

goo.gl/forms is 34/37 and many of the recent TPs trigger no other rule. (Well, none of them are strictly speaking recent, but anyway.) Do we really want to disable this just to add a separate watch for forms?

goo.gl/maps is a more reasonable 7/24 where only one of those 7 TPs was caught solely because of this rule.

gparyani commented 4 years ago

Fixed in #3813