search

Charcoal-SE / SmokeDetector

Headless chatbot that detects spam and posts links to it in chatrooms for quick deletion.
https://metasmoke.erwaysoftware.com
Apache License 2.0
474 stars 182 forks source link

!!/report sometimes breaks Smokey #565

Closed j-f1 closed 7 years ago

j-f1 commented 7 years ago

Sometimes, Smokey will silently die when !!/report is called. This does not happen every time, and Smokey doesn’t restart or reply to the message. This seems to happen more frequently when !!/reporting Ask Ubuntu questions.

AWegnerGitHub commented 7 years ago

Thank you for posting this issue.

Developers/Troubleshooters/Users of Smokey/Bug Causers:

Due to the nature of this bug and our difficultly in reliably replicating it, we need to keep this issue updated with a few key details when the issue occurs. Hopefully this will help us track down the bug directly or a pattern we can use to replicate the issue:

teward commented 7 years ago

Also include a link to what you reported, so we can see if it's an issue with odd characters or such in the reported item's content that could have broken the chat socket or something. (As well, any additional information you can provide could be useful as well).

Note that we did some testing on this to try and replicate the chat failure with a debugger attached and couldn't replicate the failures that we've seen.

j-f1 commented 7 years ago

Since spam posts usually get deleted quickly, you might want to inline them like this:

Post Link > Post contents

Code:

<details><summary><a href="//charcoal-se.org">Post Link</a></summary>

> Post contents

</details>
AWegnerGitHub commented 7 years ago

Failure:

Undo1 commented 7 years ago

Success:

Glorfindel83 commented 7 years ago

Reporting from FDSC doesn't seem to work either. Is that related to this, or is that solely a MS-FDSC thing?

double-fault commented 7 years ago

Reporting from FDSC doesn't work for me either. I flagged a post today as rude, but till I noticed that it was not reported it was already gone.

teward commented 7 years ago

Check on MetaSmoke to make sure your report didn't reach there - it's possible Smokey isn't reporting but MS is actually receiving the report.

Glorfindel83 commented 7 years ago

I have checked, but it didn't reach MS either.

On 4 March 2017 at 11:37, Thomas Ward notifications@github.com wrote:

Check on MetaSmoke to make sure your report didn't reach there - it's possible Smokey isn't reporting but MS is actually receiving the report.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Charcoal-SE/SmokeDetector/issues/565#issuecomment-284143290, or mute the thread https://github.com/notifications/unsubscribe-auth/AXeJRsCgjkZGKgbA5SAtM9vJupv_xO3rks5riT8CgaJpZM4MSWW2 .

Undo1 commented 7 years ago

@teward Metasmoke doesn't store anything from manual report requests, it just passes them along to Smokey. You wouldn't see a post record being created, ever, if it isn't reported to chat.

angussidney commented 7 years ago

Failure: 


 - Chat message: http://chat.stackexchange.com/transcript/message/35837708#35837708
 - Time: approx 10:13am UTC
 - Last known alive time: directly beforehand (used !!/alive)
Glorfindel83 commented 7 years ago

Success:

I think the second is good choice. Example: Is there anyone working in civil engineering outsourcing services in US

Glorfindel83 commented 7 years ago

Here is another !!/report for a StackApps question which didn't break Smokey.

angussidney commented 7 years ago

2 Successes:

Undo1 commented 7 years ago

Success:

NobodyNada commented 7 years ago

Failure:

The report did not appear in either Metasmoke or SOCVR.

NobodyNada commented 7 years ago

Failure:

Undo1 commented 7 years ago

@NobodyNada may have just fixed this in #568 - see discussion there. TL;DR is that we weren't releasing the lock on the API in some cases, and we have metasmoke stats that back up that theory.

FelixSFD commented 7 years ago

Success:

ghfhfhghghgghgjxdbfsbdfuidbnfeduifbnsuifhsdjifsud9hnfjbugtgggggg

teward commented 7 years ago

I think that since we haven't hit a lockup in 3 days, we can safely assume the API locking issue was the cause. Closing.