Closed AWegnerGitHub closed 7 years ago
Code admins can approve PRs or directly blacklist, so we don't actually have problems about authors approving their own requests. The only time approvals come into it is if a non-code-admin fires a blacklist request, in which case they can't approve it because they're not a code admin.
Why was this closed? Is there code which allows us to !!/approve from chat now? (Or should #886 be reopened?)
because [status: deferred]. If/when someone gets around to finishing this, it can get reopened.
Not much point having this one as a chat command; in order to find out the PR number you have to open up GH, where you can easily type the approve command anyway. I'm happy to leave this one closed.
You can hover the link to find the number, but I tend to agree it's marginal value - which is why status-deferred exists.
With the new PullApprove integration, it'd be nice if we could add an "!!/approve" to the issue from SE Chat.
This will probably need the following changes: