search

Charcoal-SE / SmokeDetector

Headless chatbot that detects spam and posts links to it in chatrooms for quick deletion.
https://metasmoke.erwaysoftware.com
Apache License 2.0
474 stars 182 forks source link

Posts which trigger only experimental reasons should only generate notifications in Charcoal HQ #949

Closed tripleee closed 7 years ago

tripleee commented 7 years ago

There is a code path which is supposed to do this, but it's apparently not working. Here is an experimental-only hit which was evidently reported in SObotics:

https://chat.stackexchange.com/transcript/message/38729208#38729208

tripleee commented 7 years ago

Looks like it actually works precisely the wrong way around!

https://metasmoke.erwaysoftware.com/post/76990 only triggered an experimental (watch) reason. It was not reported in Charcoal but was reported in SOCVR.

ArtOfCode- commented 7 years ago

Sounds like someone over-negated a boolean....

tripleee commented 7 years ago

Closing as hopefully fixed. We'll have to wait for a low-score post to see whether it behaves as expected but if not, just reopen.

tripleee commented 7 years ago

This one was reported in Charcoal and I believe only in Charcoal, so this seems to be properly done:

https://chat.stackexchange.com/transcript/message/38894750#38894750

Tangentially, that's an FP related to https://github.com/Charcoal-SE/SmokeDetector/issues/948