Charcoal-SE / metasmoke

Web dashboard for SmokeDetector.
https://metasmoke.erwaysoftware.com
Creative Commons Zero v1.0 Universal
43 stars 34 forks source link

Clicking "Spam flag" link results in routing error #137

Closed Glorfindel83 closed 7 years ago

Glorfindel83 commented 7 years ago

The spam flag which is sometimes visible in a report leads to a 404, e.g. https://metasmoke.erwaysoftware.com/post/59564/spam_flag

According to the discussion following this chat message, it's because of a wrong HTTP verb.

Also reported by QPaysTaxes.

j-f1 commented 7 years ago

If the browser uses the GET method, it could render https://metasmoke.erwaysoftware.com/post/59564 and show a confirmation popup.

ArtOfCode- commented 7 years ago

That's a POST route; hitting it with GET will 404. Does this happen when you click the link from the post page?

Glorfindel83 commented 7 years ago

Yes it does.

Sent from my iPhone (and therefore likely to contain typing errors)

On 11 Mar 2017, at 22:51, ArtOfCode notifications@github.com wrote:

That's a POST route; hitting it with GET will 404. Does this happen when you click the link from the post page?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Undo1 commented 7 years ago

What browser?

NobodyNada commented 7 years ago

@Undo1 This happens to me in the latest version of Safari.

Undo1 commented 7 years ago

Interesting, norepro in 10.1 for me.

NobodyNada commented 7 years ago

Here's a screenshot (I'm on my phone at the moment):

image1

It says something about verify_developer; could it happen to me since I'm not a dev?

From Jonathan

On Mar 13, 2017, at 8:50 PM, Parker Erway notifications@github.com wrote:

Interesting, norepro in 10.1 for me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

angussidney commented 7 years ago

@NobodyNada that didn't come through by the looks of it, could you re-upload the image when you get to a computer?

NobodyNada commented 7 years ago

Screenshot uploaded; sorry I forgot. GitHub doesn't want to display it for some reason; you'll have to click the link.