Charcoal-SE / metasmoke

Web dashboard for SmokeDetector.
https://metasmoke.erwaysoftware.com
Creative Commons Zero v1.0 Universal
43 stars 34 forks source link

Tpu feedback from MS review #238

Closed JohnMiliter closed 7 years ago

JohnMiliter commented 7 years ago

I like the review interface, but I am tired of going back to chat later after reviewing to manually blacklist spammers via the !!/addblu command

I think it would be nice if the spam / abusive button in the metasmoke review gave tpu feedback instead of tp feedback (I tested it, and unless another user was messing with the blacklist in another room, or there is a very long delay, that button does not auto-blacklist users). If this was made the case, a separate "tp" or "vandalism" button should be added.

JohnMiliter commented 7 years ago

(Sorry if posted in the wrong place)

tripleee commented 7 years ago

I'm thinking this is because of an architectural disconnect -- Smoke Detector runs in chat, Metasmoke doesn't, and so it would have to grow a chat interface after all in order to communicate the blacklisting to Smoke Detector.

angussidney commented 7 years ago

AFAIK the full functionality is there to blacklist stuff via the MS websocket (because that's how the API blacklists stuff), it's just that it needs to be implemented for review.

Edit: here we go https://github.com/Charcoal-SE/SmokeDetector/blob/master/metasmoke.py#L94