search

Charcoal-SE / metasmoke

Web dashboard for SmokeDetector.
https://metasmoke.erwaysoftware.com
Creative Commons Zero v1.0 Universal
43 stars 34 forks source link

Code coverage link is broken. Fix or remove? #449

Closed thesecretmaster closed 6 years ago

thesecretmaster commented 6 years ago

The "code coverage" link in the readme (at the very end, under "References") is broken. I don't know if anyone uses it, so we could probobly just remove it, if it isn't an easy fix. The link currently points to https://circleci.com/api/v1/project/Charcoal-SE/metasmoke/latest/artifacts/0/home/ubuntu/metasmoke/coverage/index.html

Undo1 commented 6 years ago

Should be something that got broken in the API v1 -> v2 migration. Should be fixable.

thesecretmaster commented 6 years ago

For refrence, here's JSON for all artifacts: https://circleci.com/api/v1.1/project/github/Charcoal-SE/metasmoke/latest/artifacts

thesecretmaster commented 6 years ago

Seems to me like there's no way to link directly anymore. However, we could make it link to a magic route on the CHQ website which does JS magic to redirect you to the real link to code cov.

Undo1 commented 6 years ago

Yep, looks harder than I thought. I don't think coverage is too important at this stage; closing. Anyone is welcome to attempt to revive it if they'd like.