Filtering NAA shows a lot of posts with all TP feedback?

Charcoal-SE / metasmoke

Web dashboard for SmokeDetector.

https://metasmoke.erwaysoftware.com

Creative Commons Zero v1.0 Universal

43 stars 34 forks source link

Filtering NAA shows a lot of posts with all TP feedback? #469

Closed iBug closed 6 years ago

iBug commented 6 years ago

Sample search

This has been around for some time. The actual issue is that all-TP posts are recognized as both TP and NAA in search results, You see a page full of ticks, without a single crap, but still NAA (2) on the tabs.

capture

BTW, not sure if it's the same issue, the feedback'd post type numbers (TP/FP/NAA) on the front page and search page are different. The former is about 3% larger than the latter, and this ratio is consistent across all three types of feedbacks.

thesecretmaster commented 6 years ago

Just a note, that PR doesn't fix this issue. It stops it from occurring more in the future. To retroactively fix it, you'd need to run Post.all.each(&:update_feedback_cache).

angussidney commented 6 years ago

Users with the developer role have the ability to fix this on a case-by-case basis, but by the looks of it there are too many posts to manually fix.

Would @Undo1 be able to help with this issue?

ArtOfCode- commented 6 years ago

A migration can solve this automatically. I'll write one up.