Charcoal-SE / metasmoke

Web dashboard for SmokeDetector.
https://metasmoke.erwaysoftware.com
Creative Commons Zero v1.0 Universal
43 stars 34 forks source link

Regex in mysql #477

Closed thesecretmaster closed 6 years ago

thesecretmaster commented 6 years ago

Recently, we (mostly @iBug, thank you) have added support for various regex features into search_helper.rb. Are we going to continue doing this? Or do we want to revisit getting actual PCRE support by migrating to maria db or using a mysql plugin (if one exists)?

This was also mentioned in #258 and #351.

tripleee commented 6 years ago

My personal opinion is definitely that we should be looking towards migrating to MariaDB instead and get rid of this cruft. For the record, Debian out of the box now gives you MariaDB if you try to install MySQL and some wacky hacks are required to actually install MySQL instead. (Thus the metasmoke Docker image also lands on MariaDB currently.)

thesecretmaster commented 6 years ago

@Undo1 Did you ever actually do that prod migration to MariaDB that was mentioned at some point? If not, maybe worth a try.

Undo1 commented 6 years ago

Nope, never did. Did your test instance work well?

thesecretmaster commented 6 years ago

@Undo1 It worked, but I took it down after about an hour because I thought you were migrating on prod (see this conversation)

ArtOfCode- commented 6 years ago

Now on MariaDB.