search

Charcoal-SE / metasmoke

Web dashboard for SmokeDetector.
https://metasmoke.erwaysoftware.com
Creative Commons Zero v1.0 Universal
43 stars 34 forks source link

Flag log for a post should include failures #625

Closed tripleee closed 4 years ago

tripleee commented 5 years ago

E.g. https://metasmoke.erwaysoftware.com/post/174862/flag_logs shows 3 successes but no failures, whereas https://metasmoke.erwaysoftware.com/flagging/logs?filter=failures reports one failure for this particular post (for Makyen).

makyen commented 5 years ago

That was a failure on a manual flag. Manual flags, and their failures, are not normally displayed in the MS flag logs page (there was another issue about that, Flag Logs empty, Issue #561).

I agree that it would be good for the flag logs page to include manual flags and their failures. IIRC, including manual flags on the flag logs page is on the to-do list.

thesecretmaster commented 5 years ago

I have code locally to fix this (just removing a where(is_auto: true)), but since this exposes additional flagging information, I'd like @Undo1 to sign off first.

ArtOfCode- commented 5 years ago

@thesecretmaster Undo's sign-off can be implied from his thumbs-up up there ^. You can have my sign off too - just make sure it's clear which flags are manual vs. auto and successful vs. failed.