Metasmoke is doing things multiple times

Charcoal-SE / metasmoke

Web dashboard for SmokeDetector.

https://metasmoke.erwaysoftware.com

Creative Commons Zero v1.0 Universal

43 stars 34 forks source link

Metasmoke is doing things multiple times #775

Open user12986714 opened 4 years ago

user12986714 commented 4 years ago

It appears that when performing some actions on metasmoke, it will be automatically repeated for some integer times:

Create feedback on post: sometimes 2
Add domain link: always 3
Auto creation of domain: sometimes 2

This is probably not the intended behaviour of metasmoke.

ArtOfCode- commented 4 years ago

This is probably the same old JS bug that's existed forever, probably related to Turbolinks

user12986714 commented 4 years ago

Looks like this issue is now resolved.

makyen commented 4 years ago

The recent change I made to JavaScript event handlers may have reduced the problems, and solved some of them, but it did not resolve all of them. In particular, I can still create multiple feedbacks on the same post.

At least the multiple feedbacks, and some other issues, are the result of a user being permitted to rapidly click twice on the same control. There will be another set of JavaScript changes to resolve that, but I want to make sure the most recent change didn't result in any problems.

makyen commented 3 years ago

The feedback issue was addressed in PR #823 and PR #825.

tripleee commented 2 years ago

Related? #563

makyen commented 2 years ago

Grumble, grumble, multiple things in one issue. :;