search

Charcoal-SE / metasmoke

Web dashboard for SmokeDetector.
https://metasmoke.erwaysoftware.com
Creative Commons Zero v1.0 Universal
43 stars 34 forks source link

Don't post "feedback recieved" messages from review #811

Closed NobodyNada closed 4 years ago

NobodyNada commented 4 years ago

We're starting to hit ratelimiting issues when lots of people are reviewing: https://chat.stackexchange.com/transcript/message/55513640#55513640 Could we disable those messages for feedbacks created from review, except perhaps in cases of conflicting feedback? IMO it shouldn't be a huge transparency issue, since we have 2 people review each post anyway. Either way, we can always revert the change after The Barbequeue is over.

I would make the change myself, but I don't know the best way to go about it. The feedback is created here, but I don't know how we would go about passing a parameter into feedbacks.create such that it is accessible from the after_create handler that posts the message to chat.

makyen commented 4 years ago

I'd rather see if we could post these as a second user (e.g. a "metasmoke" user), which would give us both the messages and prevent ratelimiting.

Even if we have to hack up an alternate SD instance to post just these (actually really easy), that would probably be better.

NobodyNada commented 4 years ago

Neat idea! If I have a little extra time I might as well go ahead and implement that myself.

Do you think it would be best to just use ChatX to have MS log into SE chat itself and post the message directly?

makyen commented 4 years ago

I'm unsure what the most convenient method of doing it would be. So far, the architecture has been that these messages have been sent to SD and that SD was the thing which interacted with chat (i.e. not having MS actually interact with chat). To keep the same architecture, it would probably be reasonable to have each SD instance log into SE chat as two users.

However, in the short run, that's probably a bit more work than we want right now. My initial thinking was to just run an SD instance which had been given different chat credentials (i.e. for an MS account) and have that instance deal only with MS WebSocket relay messages and change the base SD code to just drop those, rather than forwarding them to chat.

The above is something we could get working in a few minutes/half hour.

A more robust and long-term solution could be then worked out (i.e. verifying that we can easily log into two separate chat accounts with ChatExchange, etc.).

teward commented 4 years ago

@makyen can we temporarily make a configuration option that will disable review reporting then? At least as a short term solution because we're in 'purge the queue' mode with the reviewers right now.

Alternatively, should we consider putting a Metasmoke option in that lets admins shut off the trickle of feedback to SD and the chat room as another temporary measure?