search

Charcoal-SE / metasmoke

Web dashboard for SmokeDetector.
https://metasmoke.erwaysoftware.com
Creative Commons Zero v1.0 Universal
43 stars 34 forks source link

Deletion watcher missing some messages? #928

Closed tripleee closed 2 years ago

tripleee commented 2 years ago

What problem has occurred? What issues has it caused?

Shadow complained about a message which got reported in the Tavern even though it was already deleted.

Speculations abound, but the message still isn't reported as deleted in metasmoke.

https://chat.meta.stackexchange.com/transcript/message/9228055#9228055

What would you like to happen/not happen?

The deletion watcher should have noticed that the message was deleted, and ideally have removed the message from the Tavern if it was posted before the message was deleted, or else not have posted it at all.

ThatRyanPerson commented 2 years ago

If it's the issue I've been seeing, if the post is deleted before the MS report is complete, then the deletion watcher won't catch it. That doesn't generally happen unless a mod nukes it very quickly...which appears to have happened here, as it's at -1 and deleted 19 seconds after it was posted. As a Stack Overflow mod who frequently reports to Charcoal, it's not at all uncommon for me to nuke the post a little too quickly before the deletion watcher is ready, so I've seen this a bunch of times. Of course, the room where it's supposed to auto-delete is on SO chat, so I tend to solve it by deleting the messages myself... Basically, it requires deleting the post after SD has read the contents, but before it's reported to MS.

makyen commented 2 years ago

This appears to be entirely about deleting or not posting SD reports in chat when a post has been deleted, rather than something on MS. So, this is actually an SD issue. However, as far as I'm aware this has been resolved. So, rather than move it to the SD repo, I'm just going to close it.