search

Charcoal-SE / userscripts

Collection of userscripts that are used by/are useful to Charcoal.
https://charcoal-se.org/scripts
Apache License 2.0
28 stars 27 forks source link

[review-shortcuts] Ignore shortcuts while the comment box is focused #173

Closed NobodyNada closed 1 year ago

NobodyNada commented 2 years ago

Previously, if the user typed a comment containing (e.g.) 't', 'n', or 'f', the script would instantly take action on the review item. This commit ignores shortcuts while the user is typing in a textarea.

makyen commented 2 years ago

When merged, this will need to be merged into a temporary branch and then cherrypicked onto the master branch. Merging it directly into the master branch would result in multiple other commits which are not intended to be part of this PR, which we don't want, being pulled into the master branch. The need for that is why I changed the merge target branch.

Basically, it's more housekeeping. However, it doesn't really increase the work all that much, given that we would need to generate the commit(s) necessary to, at least, change the script's version number.