search

Charcoal-SE / userscripts

Collection of userscripts that are used by/are useful to Charcoal.
https://charcoal-se.org/scripts
Apache License 2.0
28 stars 27 forks source link

AIM: live deletion information isn't always processed correctly #49

Closed Glorfindel83 closed 7 years ago

Glorfindel83 commented 7 years ago

Sometimes (in ±5% of the cases), a deletion log from the websocket isn't processed correctly. Last days, I've seen it happen only for AskUbuntu posts, but I don't know if that has something to do with the issue.

angussidney commented 7 years ago

I wouldn't be surprised if something just errored out in transmission

Glorfindel83 commented 7 years ago

I just saw a case where the websocket did send a deletion_log message for an AskUbuntu question, but it still wasn't greyed out by AIM.

Glorfindel83 commented 7 years ago

The problem is that for AskUbuntu messages, two deletion logs are sent (within 50 milliseconds) instead of one. While this is probably something that @Undo1 or @ArtOfCode- should fix in metasmoke, we can also use addClass("ai-deleted") instead of toggleClass("ai-deleted").

honnza commented 7 years ago

why ... have you been using toggleClass instead of addClass?

On Sat, Mar 4, 2017 at 10:27 AM, Glorfindel83 notifications@github.com wrote:

The problem is that for AskUbuntu messages, two deletion logs are sent (within 50 milliseconds) instead of one. While this is probably something that @Undo1 https://github.com/Undo1 or @ArtOfCode- https://github.com/ArtOfCode- should fix in metasmoke, we can also use addClass("ai-deleted") instead of toggleClass("ai-deleted").

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Charcoal-SE/userscripts/issues/49#issuecomment-284139753, or mute the thread https://github.com/notifications/unsubscribe-auth/ADwF_ULCYlTM-N19wwpPs8NQWf5aHjQnks5riS56gaJpZM4ML_tX .

Glorfindel83 commented 7 years ago

IDK - I think angus counted on the websocket message being sent only once.