search

Charestlab / pyGLMdenoise

python implementation of GLMdenoise
6 stars 6 forks source link

Python 3.6 + 3.7? #63

Closed arokem closed 5 years ago

arokem commented 5 years ago

First of all, thanks for your work on this project. I have been dreaming of doing something like this, but never found the time and wherewithal, so I am very grateful that you did it!

Second, is there any particular reason you are not testing on 3.6 and 3.7 yet?

iancharest commented 5 years ago

Hey Ariel, thanks ! I'm not sure I understand your question. We've developed this using 3.6 I believe. Are there specific unit tests you see missing that you think we should include? (we have a lot of these to write still..)

iancharest commented 5 years ago

ok I get it now. Did you stumble upon version problems with our code? any issues we should be aware of?

arokem commented 5 years ago

No issues on my end, but I thought that it would be polite to ask before showing up with a PR against your travis configuration :-)