ols inv when zero regressors

Charestlab / pyGLMdenoise

python implementation of GLMdenoise

6 stars 6 forks source link

ols inv when zero regressors #74

Open iancharest opened 3 years ago

iancharest commented 3 years ago

If a condition is say only repeated every other run, we end up with design matrices with all zeros on the column for that condition on the run it wasn't presented.

This will trigger an error in 2 of our core functions fit_runs and make_project_matrix.

This PR intends to fix this.

[x] handle zeros in fit_runs
[x] handle zeros in make_project_matrix

iancharest commented 3 years ago

I think this is it. I think this might also fix #47

iancharest commented 3 years ago

tests pass.

iancharest commented 3 years ago

ok had a quick look and it seems it doesn't fix #47. i'll look into that one now.

iancharest commented 3 years ago

ok this branch is ready for merge is your review is positive.