Closed malsyned closed 1 year ago
I believe I've found the source of the problem. According to the dissector API documentation, value_string
arrays must end with a sentinel { 0, NULL}
to indicate the end of the array. The value_string
arrays in this plugin don't. This probably doesn't cause any problems during normal packet dissection, since entries are looked up by value, but it does keep Wireshark from knowing how to enumerate the values for -G value
.
I would guess it would also cause buggy behavior in the event of a field that contained an out-of-range value without a matching value string.
tshark -G values
lists the possible values of all fields, including everyvalue_string
associated with a value of a field. However, when it gets to listing the values ofv2giso2.struct.evsestatus.evsenotification
, it lists the two correct ones,StopCharging
andReNegotiation
and then keeps on listing value strings associated with different v2giso2 fields.