ChargePoint / wireshark-v2g

Dissector for the V2G Protocols
Other
43 stars 18 forks source link

"Unknown BER" in Info column for PaymentDetailsReq #54

Closed JeremyWhaling closed 6 months ago

JeremyWhaling commented 8 months ago

For PnC sessions, I am seeing the info column as "Unknown BER" for the "PaymentDetailsReq" message. Protocol column also shows "BER" instead of "ISO1". I can provide PCAPs if necessary to show this. This does not appear to show in EIM sessions as I believe the PaymentDetailsReq/Res messages are skipped. BER

chardin-cpi commented 8 months ago

we try to use a BER decoder for certificates - the problem is that if the decoder fails on an invalid cert there isn't a great way to find the error to my knowledge - so, yes sending some pcaps would help but check the certs in use on the test since that is the interlock on the BER encoding.

cc: @jhart-cpi @pthompson-cpi

barsnick commented 8 months ago

I consider this a display issue, that the BER error is propagated to the Protocol and Info columns. (I have no idea how to avoid it, yet.)

barsnick commented 8 months ago

It's also unfortunate that the Wireshark certificate function throws the BER error (and apparently propagates it), but the BER error is not visible in the display of the certificate, which I assume is also a Wireshark function - the "ber" dissector.

Screenshot 2023-12-14 102702

chardin-cpi commented 6 months ago

so, I tried a few things to try and fix this and just haven't been able to - I am willing to take a patch that someone comes up with but I ran out of ideas.

closing this ticket since I am not sure if it can be fixed on how Wireshark propagates the errors.