search

ChargePoint / wireshark-v2g

Dissector for the V2G Protocols
Other
43 stars 18 forks source link

Typo "EVMaximumPowertLimit" should be "EVMaximumPowerLimit" #60

Closed JeremyWhaling closed 4 months ago

JeremyWhaling commented 5 months ago

Found a typo in the dissector: image

Appears to be on line 2227 in packet-v2gdin.c: if (dc_evchargeparameter->EVMaximumPowerLimit_isUsed) { dissect_v2gdin_physicalvalue( &dc_evchargeparameter->EVMaximumPowerLimit, tvb, pinfo, subtree, ett_v2gdin_struct_dinPhysicalValueType, "EVMaximumPowertLimit");

Also line 2309 in packet-v2giso1.c: if (dc_evchargeparameter->EVMaximumPowerLimit_isUsed) { dissect_v2giso1_physicalvalue( &dc_evchargeparameter->EVMaximumPowerLimit, tvb, pinfo, subtree, ett_v2giso1_struct_iso1PhysicalValueType, "EVMaximumPowertLimit");

Not present in packet-v2giso2.c. I think the breakout I requested back in issue #50 wasn't added to that flavor of dissector, but I don't use it so doesn't matter to me. :)

jhart-cpi commented 4 months ago

Should be fixed in https://github.com/ChargePoint/wireshark-v2g/pull/58