search

Charged / Miners

An Game Engine and Minecraft Classic Client
charged-miners.com
87 stars 14 forks source link

mc: Render furnaces correctly. #7

Closed squiddy closed 13 years ago

squiddy commented 13 years ago

Hello,

That's my first attempt for a contribution to your project, so I'd highly appreciate feedback/critic. I'm still getting comfortable with the code, so I'm not sure if that's the way to do it. From what I understand, texture positions in data.d only work for the simple cases, when all sides share the same texture. That's why I changed the default texture of the furnace to the side texture, and conditionally exchange it for the front texture.

I originally started working on beds, but ran into some problems so I thought this might be a better starting point.

squiddy commented 13 years ago

I've applied the changes, I think it does look better now.

I'm not sure if you prefer merge-ready branches (in that case I could squash those commits and issue a new pull request), or if you'll do the squash yourself.

Wallbraker commented 13 years ago

If its not to much trouble for you can you please squash them yourself?

Cheers Jakob.

squiddy commented 13 years ago

Sure, no problem. Here you go: https://github.com/squiddy/Charged-Miners/commit/ee858f9112656e42fcaa9dfd0724295cb3b1027e (Branch https://github.com/squiddy/Charged-Miners/commits/improve_furnace_rendering)

Wallbraker commented 13 years ago

Merged the commits in the last message, via the Fork Queue.

Cheers Jakob.