search

Charged / Miners

An Game Engine and Minecraft Classic Client
charged-miners.com
87 stars 14 forks source link

mc: Rudimental support for signposts. #9

Closed squiddy closed 13 years ago

squiddy commented 13 years ago

I'm not sure if this is worth pulling into master, the signs aren't really pretty. But it might be better than nothing.

Wallbraker commented 13 years ago

I think you got the rotation wrong, I threw this together it looks sort of correct.

https://gist.github.com/0f7c0f5698f9bc870017

Cheers Jakob.

squiddy commented 13 years ago

You're right, I did a last minute change and probably broke it. With your change it looks fine. Shall I integrate it into mine or will you do it? Is the rest of the patch acceptable?

Wallbraker commented 13 years ago

The patch looks good, just integrate my changes and rebase it ontop of my master please.

squiddy commented 13 years ago

Looks like github supports overwriting branches in pull request, so here you go.