Charles1026 / pe

0 stars 0 forks source link

Adding Duplicate Tag/Note/Plan neither creates an error message nor adds it. #9

Open Charles1026 opened 1 year ago

Charles1026 commented 1 year ago

After adding the first instance of a Tag/Note/Plan, adding a duplicate instance does not cause any errors, yet it does not get added. This may create confusion for the user as he/she may assume it has been added.


video:https://raw.githubusercontent.com/Charles1026/pe/main/files/a9245684-126f-4168-9dd3-19c927ee405c.mp4

soc-se-bot commented 1 year ago

Team's Response

This is expected behaviour. It would not make sense to add duplicate tags, plans, or notes, as these items are meant to be unique within each client. For example, it would not make sense for the client to have 2 NTUC Income Health plans in their plans, since a client can only either be subscribed to a plan or not be subscribed to a plan, and there is no such thing as subscribing to a plan twice. Similarly for tags and notes, it does not make sense to hold duplicates.

Hence, any duplicate tags, plans and notes is neither added or not added: it will be automatically ignored by the command as it already exists.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: with reference to the below image, prof has deemed the issue below, which is the same as your issue a bug, hence it should not be rejected.

image.png