Charles445 / SimpleDifficulty

Difficulty mod based on Tough as Nails
MIT License
14 stars 9 forks source link

First aid integration #22

Closed ichttt closed 3 years ago

ichttt commented 3 years ago

This is a initial implementation of FirstAid compatibility in SD. It only covers a damage distribution thrist, as shivaxi and I concluded that the default random distribution is appropiate for the other damage sources. Tested and confirmed to be working

Charles445 commented 3 years ago

Would the 'load after' dependency be necessary if the compat initialization ran on postInit instead? I think First Aid finalizes the registry on loadComplete so I don't think there'd be any race condition issues

ichttt commented 3 years ago

The load order dependency isn't strictly needed, but I included it for a version check, so you don't run into issues with too old firstaid versions

Charles445 commented 3 years ago

Mind if I fiddle with this after I pull it? I plan on refactoring this over to the compat mod folder, turn it into a soft dependency like the others, move it to postInit, remove the version check, and add a firstaid hardmode check

ichttt commented 3 years ago

go ahead, do as you like. It's you mod after all :P