CharlesBlonde / libpurecoollink

Dyson Pure Cool link python library
http://libpurecoollink.readthedocs.io
Other
205 stars 54 forks source link

add support for dyson.cn devices #11

Open daxingplay opened 6 years ago

daxingplay commented 6 years ago

Hi, dyson has chosen another domain instead of language code in url params for Chinese customers. So I submitted this PR to add support for api.cp.dyson.cn domain when language code is CN. I'm not quite familiar with python, so I wonder whether my modification is suitable and I'm not sure how to add a proper test case for it. But I had tested manually with my own Pure Hot Cool Link device bought in China. It works well as expected. Thanks.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 99.101% when pulling 152d85c8fc3bb14d455fd822fb2db8d48b9236b8 on daxingplay:master into a91362c57a0bc4126279c8c51c407dd713b08e10 on CharlesBlonde:master.

CharlesBlonde commented 6 years ago

Hi @daxingplay ,

Thanks for this PR and I'll take a look as soon as possible.