CharlesGillanders
commented
2 years ago I have just pushed a new branch in which I want to incorporate current system settings (including the discharge/charge settings) into the response returned back from the GetData query.
That code and your code for grabbing the response from the GetCustomUseESSSetting API call are very similar but I have changed my code slightly.
- I have made an assumption that anyone with more than one ESS system will receive an array response back from AlphaESS with the serial number of each separate ESS system identifying the appropriate settings. Unfortunately I cannot test that assumption as I don't have more than one ESS system but I feel it's important to try to make this work for all cases.
- I have chose to simplify the data response and I pop the serial number out of the data returned back to the callee in GetData.
Could you please take that new branch and revise your code so that your methods for setting charge and discharge use my code for the GetCustomUseESSSetting's call - that will ensure that we only need one method for getting the settings and not two. I'll accept the pull request against the revised branch and once that's working I can push the combined changes to the mainline
@CharlesGillanders I've replicated the api calls to set the battery charge/discharge state and added 2 methods to set charge/discharge settings. If this is accepted then I can look into adding the service to the home assistant integration.