Small QOL improvements - Githubissues

CharlesGillanders / homeassistant-alphaESS

Monitor your energy generation, storage, and usage data using the official API from Alpha ESS.

MIT License

101 stars 22 forks source link

Small QOL improvements #123

Closed Poshy163 closed 3 months ago

Poshy163 commented 3 months ago

Move EMS Status to Diagnostic view
Add support for custom icons (currently for self-consumption, self-sufficiency and total income)
Add maximum battery capacity sensor
Add installed and current capacity diagnostic sensor

CharlesGillanders commented 3 months ago

Hi @Poshy163, you'll note that having merged the previous pull request there is now a merge conflict in this one. Let me know if you are able to modify the pull request to eliminate the conflict?

Poshy163 commented 3 months ago

That should of fixed it?

CharlesGillanders commented 3 months ago

That should of fixed it?

It looks to me that the default value for minv and emsStatus are not being passed into process_value, either that or I'm just reading the merge conflict incorrectly (also very possible).

This is the current code that's in main branch:

inverterdata["Model"] = await process_value(invertor.get("minv"), 0) inverterdata["EMS Status"] = await process_value(invertor.get("emsStatus"), 0)

The pull request seems to have:

inverterdata["Model"] = await process_value(invertor.get("minv")) inverterdata["EMS Status"] = await process_value(invertor.get("emsStatus"))

CharlesGillanders commented 3 months ago

Ignore me! I just saw that the process_value code was also updated to remove the need for the default. I'll get this merged now.

Poshy163 commented 3 months ago

haha, cheers man!

CharlesGillanders commented 3 months ago

Something has gotten broken somewhere, there are several of your changes (including the switch from default value to 0) that now appear to be missing from the pull request and the checks are failing due to indenting. Is the easiest fix to cancel this PR and submit a new one?