Closed Poshy163 closed 3 weeks ago
@Poshy163 - you've been busy on this for quite a while, let me know when you want it merged with the repo.
Haha yeah, would of been done a while ago before Alpha went to shit with all the API issues 😅
Should be done soon, just verifying nothing will break for most people
@CharlesGillanders, you mind giving me write access to the repo incase this goes pear shape for the Storion-S5 invertors (and possibly more) and i need to push an update ASAP after this is released?
i have a feeling it should work, and from what ive talked with elevenfan in the slack channel about what parameters it supports, he said it "should" and when i asked for proof, he said he would "search the database myself" and i am yet to hear back about it (not a surprise)
@CharlesGillanders, you mind giving me write access to the repo incase this goes pear shape for the Storion-S5 invertors (and possibly more) and i need to push an update ASAP after this is released? I have sent an invite to you to add you as a collaborator - if that is not sufficient let me know and I'll do whatever else is needed.
if that is not sufficient let me know and I'll do whatever else is needed.
Seems to be working, i can draft/make a new release but still cant approve my own PR (you'll need to approve and merge this)
Also seems i can push directly to the repo based on this graph which is good
Might be worth moving it the role to maintainer for now?, or could just yolo it and deal with it when something inevitably goes wrong with a change this size 🤣
Might be worth moving it the role to maintainer for now?, or could just yolo it and deal with it when something inevitably goes wrong with a change this size 🤣
So a little bit of additional reading on my part suggests that when using a personal account there is very limited ability to grant additional roles or permissions. I'd need to move this repo to an organization to be able to do that. Worth considering doing but possibly more headache than is needed immediately...
Ah yeah, that's no stress. Maybe write perms are enough for just pushing any major blocking fixes out to everyone
@CharlesGillanders should be good to go now 👍🏻 i can release it if you wanna merge it
@CharlesGillanders should be good to go now 👍🏻 i can release it if you wanna merge it
All yours.
How have you added support for Force battery discharge, I don't think alpha essential have added this to the open api? Good idea adding the buttons for quick charge and the diagnostic values.
Have you also had issues with open api not setting the charge settings? mine hasn't worked since their last 'upgrade'
Force battery discharge just works by setting the discharge time to the nearest quarter of an hour.
As for if it's working, I'm having no issues (in AUS + Smile5) so that's what I was doing the tests off of