search

CharlieHess / slack-poker-bot

A bot that deals Texas Hold'em games in Slack
MIT License
1.66k stars 208 forks source link

bet ALL IN #58

Open rodrigoma opened 8 years ago

rodrigoma commented 8 years ago

Hi Charlie,

I'm not familiar with node.js, sorry if has something wrong.

here my pull request for the bet ALL IN, I'm using this implementation with my slack team since October, and works fine.

I tried to create a test for the command, but shows me a error that I don't understand.

I hope that everything is OK, I have another things that my fellows told me to do.

EDIT: looking the error on Travis CI, it's related with Slack Api

verveguy commented 4 years ago

Hi! I'm working my way through this codebase, refreshing it and pulling in the various improvements folks have made as well as making some of my own. Your mod works for the most part, but it leaves one situation a little rough. When a player who is a small blind goes "allin" before the flop, the bet computation isn't quite right and it results in them having to Call to get the rest of their blind on the table. (And thus, get to $0 remaining)

y0unghe commented 8 months ago

Hi! I'm working my way through this codebase, refreshing it and pulling in the various improvements folks have made as well as making some of my own. Your mod works for the most part, but it leaves one situation a little rough. When a player who is a small blind goes "allin" before the flop, the bet computation isn't quite right and it results in them having to Call to get the rest of their blind on the table. (And thus, get to $0 remaining)

I encounter the same issue here. When a player goes "All In" before the flop, the calculation is incorrect. Do you mind sharing the codes on how to fix this issue?