search

CharlieHess / slack-poker-bot

A bot that deals Texas Hold'em games in Slack
MIT License
1.66k stars 208 forks source link

Replace lwip with jimp image processing library #73

Open aanari opened 6 years ago

aanari commented 6 years ago

Fixes a lot of build issues with the native image processing lwip library (which I cannot get to build on Node 10 on OSX or Ubuntu), with the pure Javascript jimp implementation.

Code, tests, and dependencies have been updated to reflect this library change.

verveguy commented 4 years ago

Thanks for this work. I'm pulling the various refreshes and improvements folks have made into my fork at verveguy/slack-poker-bot. There's only one problem with jimp - the tests occasionally fail with Error: Could not find MIME for Buffer <null>. It's intermittent. Perhaps 1:3 or 1:5. Sometimes it's fine for more executions. Googling reveals many other folks have this problem with jimp from time to time but the maintainers seem to ignore the feedback as "unreproducible". Have you seen anything like this yourself?