CharlieS1103 / spicetify-extensions

extensions for spotify i'm creating
MIT License
542 stars 70 forks source link

[Adblock BUG] Describe bug. #57

Closed belalabdo1234 closed 1 year ago

belalabdo1234 commented 1 year ago

Describe bug

its blocking visual adds but since the last update it stopped blocking audio adds

Steps to replicate

just listen to music while enabling the add blocker

Necessary screenshots

Spicetify and Spotify Version

latest

Config file:

thefakequake commented 1 year ago

I also have this problem

Vyxxxx commented 1 year ago

Me too.

CharlieS1103 commented 1 year ago

@thefakequake @Vyxxxx @belalabdo1234 are any of you from Egypt?

thefakequake commented 1 year ago

nope, UK

Pokrzywnik commented 1 year ago

I also have problems. I was using old version of spotify/spicetify. Things i tried: -updated spicetify (still had ads) -updated spotify and reapply spicetify (still had ads) -uninstalled adblock extension, downloaded and installed it manually - ads still there

not from egypt, Poland here. Last time i listened (17.06.2023) it was working fine. Do you need any logs?

DeveloLongScript commented 1 year ago

i found a work around. all you have to do is run

Spicetify.Platform.AdManagers.audio.disable();

in the spotify console ( open by using Ctrl+Shift+I )

-It only works until spotify closes (so everytime you have to use that hack)-

it doesn't work i thought it would work. (don't worry im still trying to find a bypass)

potential problem (if anyone cares):

it looks like the problem is because of this error right here

adblock.js?time=1687289874022:52 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'putOverridesValues')
    at delayAds (adblock.js?time=1687289874022:52:57)

i dont know though because i didn't write this extension

or this potentially

xpui.js:1 Error: SUB request to sp://ads/v1/slots/stream failed with exception '[VTO] Unsupported event type: discard'
    at d.onSuccess (xpui.js:1:1491306)
    at onSuccess (xpui.js:1:1491026)
DeveloLongScript commented 1 year ago

alright. i found a workaround. download noWatchTime.zip, decompress and move noWatchTime into the extensions folder.

extension folder:

Platform Path
Linux ~/.config/spicetify/Extensions or $XDG_CONFIG_HOME/.config/spicetify/Extensions/
MacOS ~/spicetify_data/Extensions or $SPICETIFY_CONFIG/Extensions
Windows %appdata%\spicetify\Extensions\

then, use spicetify apply. this works every time you open the folder. enjoy!

step-by-step guide: https://gist.github.com/DeveloLongScript/7741173730c6ac3c84bf0799a465c59c

ociruu commented 1 year ago

alright. i found a workaround. download noWatchTime.zip, decompress and move noWatchTime into the extensions folder.

extension folder:

Platform Path

Linux ~/.config/spicetify/Extensions or $XDG_CONFIG_HOME/.config/spicetify/Extensions/

MacOS ~/spicetify_data/Extensions or $SPICETIFY_CONFIG/Extensions

Windows %appdata%\spicetify\Extensions\

then, use spicetify apply. this works every time you open the folder. enjoy!

step-by-step guide: https://gist.github.com/DeveloLongScript/7741173730c6ac3c84bf0799a465c59c

thank you!

CharlieS1103 commented 1 year ago

Going to roll out a patch right now

Chaxiraxi commented 1 year ago

Going to roll out a patch right now

Thanks man! I'm waiting for it.

xagzu commented 1 year ago

Is the patch out yet? The adblocker still doesn't work.

CharlieS1103 commented 1 year ago

Could I ask what version of spicetify/Spotify you're all on

Noxde commented 1 year ago

Could I ask what version of spicetify/Spotify you're all on

Im on 2.16.2

ninjadev64 commented 1 year ago

It's not blocking any ads for me, I'm on Spicetify 2.17.0

CharlieS1103 commented 1 year ago

Should be fixed now, wait up to of 24 hours to see the changes

peege-on commented 1 year ago

Should be fixed now, wait up to of 24 hours to see the changes

still playing audio ads on 2.20.1 :(

tjch-o commented 1 year ago

same it still plays audio ads on 2.20.2 for me

CharlieS1103 commented 1 year ago

@peege-on @tjch-o Are either of you from egypt

peege-on commented 1 year ago

@peege-on @tjch-o Are either of you from egypt

not me

tjch-o commented 1 year ago

nope not me

CharlieS1103 commented 1 year ago

@peege-on @tjch-o What version of spotify are you guys on?

peege-on commented 1 year ago

@peege-on @tjch-o What version of spotify are you guys on?

Spotify for Windows 1.2.13.661.ga588f749 Spicetify v2.20.2

belalabdo1234 commented 1 year ago

I'm from Egypt yes

On Tue, Jun 27, 2023, 5:20 PM Charlie @.***> wrote:

@peege-on https://github.com/peege-on @tjch-o https://github.com/tjch-o Are either of you from egypt

— Reply to this email directly, view it on GitHub https://github.com/CharlieS1103/spicetify-extensions/issues/57#issuecomment-1609607552, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAWNEHCF3DEBFCFS4EQBXYDXNLT3FANCNFSM6AAAAAAZM33XEQ . You are receiving this because you were mentioned.Message ID: @.***>

tjch-o commented 1 year ago

Spotify for Windows 1.2.14.1149.ga3ae422d Spicetify v2.20.2

DeveloLongScript commented 1 year ago

If you guys are still having ads then use the patch i made above ^^^^^^

CharlieS1103 commented 1 year ago

If you guys are still having ads then use the patch i made above ^^^^^^

I rolled out a patch which should resolve the issue mentioned.

omelkonian commented 1 year ago

I'm afraid I am still hearing ads:

xagzu commented 1 year ago

I am hearing advertisments aswell.

EdentheDumbie commented 1 year ago

i also have this issue (im from israel if that helps) and im on the newest version of everything