search

Charmatzis / react-leaflet-google

GoogleMaps layer as React component for Leaflet | This repo is obsolete. Plz, use https://github.com/TA-Geoforce/react-leaflet-google
https://github.com/TA-Geoforce/react-leaflet-google
MIT License
29 stars 60 forks source link

edge tiles don't load with zoom snap < 1 #25

Open drheinheimer opened 6 years ago

drheinheimer commented 6 years ago

When react-leaflet's zoomSnap is, say, 0.5, Google tile layers often (presumably at half-level zooms) do not cover the entire view (see screenshot). For now, my solution is, of course, to use zoomSnap=1, but this should probably be fixed.

image

Charmatzis commented 6 years ago

@rheinheimer Hi, I have updated the package with some latest fixes (3.3.0). I believe that now you are OK. Can you confirm it?

drheinheimer commented 6 years ago

@Charmatzis The half-zoom issue remains.

Charmatzis commented 5 years ago

@rheinheimer is this issue remains? I have done an update.

If it remains, could you plz, develop a demo to test it?

drheinheimer commented 5 years ago

@Charmatzis Unfortunately the update seems to depends on react-leaflet 2.0, not 1.x, which breaks the customizations in my app. So there's no way for me to test this. What changes did you make to fix this?

Update: after looking into this a bit, I think maybe Google Maps doesn't support non-integer zoom levels. So the solution would be to then trick Google? Something akin to https://github.com/TolonUK/Leaflet.EdgeBuffer