search

Charn293 / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

Summary #3

Open farishkash opened 6 years ago

farishkash commented 6 years ago

Overall met expectations.

This site is great. Your organization is very good, seems to match the BEM standard of class naming. Visually the site is well done. There are some nice hover and transition effects here. The only concern being the size of the site for larger screens, which is really easy to fix.

CSS media query structure is my only concern, you only need to write it once and fit all your code into that. This avoids accidental misplacement of styles and makes it easier to find mistakes.

Now for your consideration, if you haven't already reviewed the Codecademy CSS grid course please do so. You can also go to http://cssgridgarden.com/ for additional practice. As a challenge consider converting this project and incorporating cssgrid into this.

Charn293 commented 6 years ago

Thanks Farish. I haven't done the CSS grid course. But a great suggestion and I will follow up. Likewise I will review the media query structure. Best wishes, Chris.