CharrafiMed / global-search-modal

Enhances filamentphp's global search by transforming it into a modal for a better user experience
https://filamentphp.com/plugins/charrafimed-global-search-modal
69 stars 15 forks source link

feat: add multilingual support and improve i18n handling #48

Closed kidiatoliny closed 1 month ago

kidiatoliny commented 1 month ago

Introduced translations for Spanish, French, Brazilian Portuguese, and European Portuguese. .

CharrafiMed commented 1 month ago

@kidiatoliny, thank you for your work on the translations!

I noticed that some keys in the French language JSON files need adjustments, specifically for these strings:

  "recent": "les récents",
  "favorites": "les favoris"

I know French well and can guarantee the correctness of the fr translation. I just want to ensure that the other translations are also accurate. If you could double-check them, that would be appreciated!

kidiatoliny commented 1 month ago

Thank you for the feedback, I keep learning French, here in Cape Verde our language is Portuguese. Maybe it's a good idea to leave only Portuguese and allow other native people to add the other languagesOn 19 Sep 2024, at 9:59 AM, MOHAMED CHARRAFI @.***> wrote: @kidiatoliny, thank you for your work on the translations! I noticed that some keys in the French language JSON files need adjustments, specifically for these strings: "recent": "les récents", "favorites": "les favoris"

I know French well and can guarantee the correctness of the fr translation. I just want to ensure that the other translations are also accurate. If you could double-check them, that would be appreciated!

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>