search

CharsetDetector / UTF-unknown

Character set detector build in C# - .NET 5+, .NET Core 2+, .NET standard 1+ & .NET 4+
303 stars 45 forks source link

Consider API breaking changes #121

Closed rstm-sf closed 2 years ago

rstm-sf commented 3 years ago

Hello!

Consider API breaking changes:

It seems to me that the user does not need to have access to the API from the src/Core folder. Therefore, to simplify further possible changes to the src/Core, it would be good to change to internal access. Additionally, NRT support for the remaining API can be added. But there are questions about this, see this comment.

Changes for src/Core can be marked in one of the releases as Obsolete with a link to this issue for the opportunity to express self-point. Perhaps this could be done for NRT as well?

304NotModified commented 3 years ago

Also we really need an interface an non static methods for mocking :)

304NotModified commented 2 years ago

sounds good, splitted those: