search

CharsetDetector / UTF-unknown

Character set detector build in C# - .NET 5+, .NET Core 2+, .NET standard 1+ & .NET 4+
303 stars 45 forks source link

Automatic code arrangement #157

Closed adimosh closed 2 years ago

adimosh commented 2 years ago

Removed a lot of useless whitespace, unused usings, attempted to create a usable editorconfig file.

rstm-sf commented 2 years ago

Relying only on Visual Studio formatting is not really the right solution, as Rider/Resharper has different settings (broader?) and does not support all the formatting that is specified in the .editorconfig from the Studio. Perhaps a good idea would be to look towards the dotnet-format

adimosh commented 2 years ago

While that may be true, the current state of the code does not implement anything, and the code is full of unused whitespace. While I can definitely use R# to make something better, I have seen no indication that the project collaborators intended that to be the case.

adimosh commented 2 years ago

@rstm-sf - would me removing the editorconfig file from this PR make it more merge-worthy? It's basically just code cleanup and wants to be nothing more.

304NotModified commented 2 years ago

I think this is a nice improvement:)

Haven't checked it indepth yet

304NotModified commented 2 years ago

I think this is a nice improvement. Checked that this only a whitespace changes (and also removed some unneeded imports and fixed comment typos, so nice)