Closed rstm-sf closed 4 years ago
Also, it will be necessary to indicate explicitly in the
readme
that not allEncoding
exists.
Sounds good!
And maybe it will be possible to get rid of try / catch?
That would be nice if it's 100% safe
That would be nice if it's 100% safe
Class CodepageName
was created based on .net core source :)
All unsupported can be added to some object and check before calling Encoding.GetEncoding(string)
Nice! I checked a lot of files, but missed that :angel:
Not supported iso-2022-ch? Maybe fix to x-cp50227?
see
https://docs.microsoft.com/en-us/windows/win32/intl/code-page-identifiers
Sorry, but the tasks is not yet completed. I wait #86
Hello!
Refactor ctor DetectionDetail(string, float, CharsetProber, TimeSpan?, string): not all codepage names are supported by .NET.
Code like
Split('(').First().Trim()
looks redundant.To do this, will need to consider that not all codepage names are supported by .NET (see
CodepageName
by #74). Also, it will be necessary to indicate explicitly in thereadme
that not allEncoding
exists.And maybe it will be possible to get rid of try / catch?
CodepageName.cs
TODO: Not supported?
-- If possible, get rid of all such or process separatelyTODO: Are other aliases ...
(I think can simply removeTODO:
because important identifier)(Optional) to get rid oftry / catch
in ctor DetectionDetailREADME.md