search

CharsetDetector / UTF-unknown

Character set detector build in C# - .NET 5+, .NET Core 2+, .NET standard 1+ & .NET 4+
307 stars 46 forks source link

Upgrade target .NET Framework 4.0 to 4.5.2 #85

Closed rstm-sf closed 4 years ago

rstm-sf commented 4 years ago

Hello!

Maybe upgrade target .NET Framework 4.0 to 4.5.2 in version 3.*?

https://github.com/CharsetDetector/UTF-unknown/blob/cc2b081a621001aedfac20229bd555585d366e9f/src/UTF-unknown.csproj#L4

Because MS don't support (see Lifecycle FAQ—.NET Framework) and some optimizations

304NotModified commented 4 years ago

What kind of optimizations your thinking of?

I prefer keeping 4.0 if it's still working.

rstm-sf commented 4 years ago

For example, in 4.5.1 GC performance has been improved

Release notes 4.5 Release notes 4.5.1 Release notes 4.5.2

304NotModified commented 4 years ago

Yes, but if a user uses .net 4.5.1, that works without changing this library.

rstm-sf commented 4 years ago

@304NotModified, Ok. Sorry, I am not so good at this yet, but I have read the documentation and it suited me. I was still just embarrassed that I could not use the optional features of the frameworks :)

I think it can be closed then