Fix todo: ISO-2022-CN is x-cp50227 in .NET

CharsetDetector / UTF-unknown

Character set detector build in C# - .NET 5+, .NET Core 2+, .NET standard 1+ & .NET 4+

303 stars 46 forks source link

Closed rstm-sf closed 4 years ago

rstm-sf commented 4 years ago

Resolve task #78

Not supported iso-2022-ch? Maybe fix to x-cp50227?

Sorry, but I could not find an example.

rstm-sf commented 4 years ago

I'm confused, I’ll fix it now

304NotModified commented 4 years ago

so 50229 is unsupported but also iso-2022-ch? But x-cp50227 is supported?

rstm-sf commented 4 years ago

Yes, I somehow wrote with a double meaning.

If you go to get the encoding by identifier 50229, then you will get an exception in .NET Framework:

System.NotSupportedException : The ISO-2022-CN Encoding (Code page 50229) is not supported.

It is possible that it was or was supposed to be ISO-2022-CN-EXT encoding.

x-cp50227 has the identifier 50227 and is ISO-2022-CN encoding according to the doc/win32.

P.S. Now I need to make 2 edits

rstm-sf commented 4 years ago

P.S. Now I need to make 2 edits

Done

304NotModified commented 4 years ago

Thanks!