search

CharsetMC / Charset

The Charset Project for Minecraft.
http://charset.asie.pl/
62 stars 30 forks source link

Module loading not working with Forge's ModList #449

Open dscalzi opened 4 years ago

dscalzi commented 4 years ago

Passing mods (modules) as mods to forge's --modListFile are not being picked up by Charset's module loader. Support should be added and backported to any supported versions.

See: https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/src/main/java/net/minecraftforge/fml/relauncher/libraries/ModList.java

cc @TheFlash787

asiekierka commented 4 years ago

That... explains quite a lot, actually. However, I am already using the ASMDataTable to query the list of loaded modules, which should be processing every mod loaded. Unless I'm doing the lookup too early, that is - I haven't looked into the modlist functionality very much, admittedly.