search

CharsetMC / Charset

The Charset Project for Minecraft.
http://charset.asie.pl/
62 stars 30 forks source link

[Storage - Barrels] Hopping barrels locked by redstone become permanently locked when world/chunk is reloaded #458

Open H-QueerCoded opened 2 years ago

H-QueerCoded commented 2 years ago

2022-07-26_21 35 09 I built this to test after encountering this problem on my server. The barrel works as expected initially, but once I quit and reload the world it no longer sends items into inventories below when the redstone signal is off.

H-QueerCoded commented 2 years ago

I tested some more and found that the issue also applies to barrels when placed in a situation which would lock them (if you place the barrel in the image last it will become permanently locked)

asiekierka commented 2 years ago

Thank you for the bug report!

H-QueerCoded commented 2 years ago

I was looking at the logic for redstone levels, why are hopping barrels being skipped here? Not sure if its the cause of the issue or just something I'm not understanding https://github.com/CharsetMC/Charset/blob/3524b3d651b3d5fa573d6a0627e91ac6f4e41cfc/src/main/java/pl/asie/charset/module/storage/barrels/TileEntityDayBarrel.java#L475

asiekierka commented 1 year ago

Sorry for not answering in so long; guess I better do so for the benefit of future lurkers as well.

The reason is that the output level concerns the redstone output of the Barrel, and with Hopping Barrels being able to take redstone input, that'd make a mess of things.