search

ChartBlocks / php-ssrs

PHP library for connecting to SSRS over SOAP
MIT License
25 stars 22 forks source link

Add blank string check for XML responses #33

Closed leith closed 5 years ago

leith commented 5 years ago

Addresses #21, #22, #31 in its simplest form.

This does not add an expansion for more specific error messages as suggested on #21 (or using something like https://gist.github.com/henriquemoody/6580488), but that could be an interesting additional update later.

Also adds a branch alias to make it easier to do fork tests.

leith commented 5 years ago

@rb-cohen is this still being maintained? If so, can this be reviewed?

rb-cohen commented 5 years ago

Yes, sorry, I remember looking at this before but can't see why it wasn't merged.