search

ChartBlocks / php-ssrs

PHP library for connecting to SSRS over SOAP
MIT License
25 stars 22 forks source link

Update NTLM.php #4

Closed deanstalker closed 9 years ago

deanstalker commented 9 years ago

There is precedence issue occurring with this ternary in later versions of PHP. Suggest wrapping in brackets to ensure the ternary stays self-contained.

rb-cohen commented 9 years ago

Hi @deanstalker,

Thanks for the pull request. Which version of PHP were you experiencing this with? I'd like to add a unit test.

Thanks,

Arron

deanstalker commented 9 years ago

Hi Arron,

We're using PHP 5.5.21.

Cheers,

Dean

On Wed, Feb 11, 2015 at 8:54 PM, rb-cohen notifications@github.com wrote:

Merged #4 https://github.com/ChartBlocks/php-ssrs/pull/4.

— Reply to this email directly or view it on GitHub https://github.com/ChartBlocks/php-ssrs/pull/4#event-233843208.

rb-cohen commented 9 years ago

Thanks, I've tagged 1.0.4 with the fix and some unit tests. Looks like it was a problem as far back as 5.3 so not sure how we got away with that for so long.

Appreciated.

deanstalker commented 9 years ago

Glad to have helped.

Cheers,

Dean

On Wed, Feb 11, 2015 at 9:26 PM, rb-cohen notifications@github.com wrote:

Thanks, I've tagged 1.0.4 with the fix and some unit tests. Looks like it was a problem as far back as 5.3 so not sure how we got away with that for so long.

Appreciated.

— Reply to this email directly or view it on GitHub https://github.com/ChartBlocks/php-ssrs/pull/4#issuecomment-73866960.