search

ChartBoost / chartboost-mediation-android-adapter-google-bidding

Chartboost Mediation Android SDK Google Bidding adapter
MIT License
1 stars 1 forks source link

Activity leak on interstitial and rewarded #55

Closed gerzalez-x3m closed 8 months ago

gerzalez-x3m commented 9 months ago

Summary of Issue

An Android activity leak is detected after displaying a rewarded or interstitial ad.

Reproduction Steps

1. fullscreenAd.showFullscreenAdFromJava(activity,listener) 
2. Destroy Activity
3. Run LeakCanary or Android Studio Memory Profiler
4. Dump memory
5. Detect that the Activity that show the ad is leaking thought com.chartboost.mediation.googlebiddingadapter.GoogleBiddingAdapter$showInterstitialAd$1 instance

Expected Behavior

No leaks after destroying the Android Activity

Chartboost Mediation Integration Details

Android Environment Details

Device Details

Additional Context

Leak Canary stacktrace analysis

Android Studio Memory Profiler screenshot
chauduyphanvu commented 9 months ago

https://github.com/ChartBoost/chartboost-mediation-android-adapter-google-bidding/pull/59

chauduyphanvu commented 8 months ago

This has been fixed in https://github.com/ChartBoost/chartboost-mediation-android-adapter-google-bidding/commit/a3b10cc37d8d4b2f37c9afcc1fd0178f68b44ca7. Thanks for the cooperation on this one!

A release should be going out any minutes now.

gerzalez-x3m commented 8 months ago

Hi Chauduyphanvu!

Great to hear that the issue has been resolved! We'll be sure to test it and let you know if everything checks out. Thanks for the update!

Best, German Gonzalez

On Mon, Jan 29, 2024, 15:33 chauduyphanvu @.***> wrote:

This has been fixed in a3b10cc https://github.com/ChartBoost/chartboost-mediation-android-adapter-google-bidding/commit/a3b10cc37d8d4b2f37c9afcc1fd0178f68b44ca7. Thanks for the cooperation on this one!

A release should be going out any minutes now.

— Reply to this email directly, view it on GitHub https://github.com/ChartBoost/chartboost-mediation-android-adapter-google-bidding/issues/55#issuecomment-1915330327, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2IEJEAQPTZGAYUSG3FOAI3YQ7TQVAVCNFSM6AAAAABBR3H4ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVGMZTAMZSG4 . You are receiving this because you authored the thread.Message ID: <ChartBoost/chartboost-mediation-android-adapter-google-bidding/issues/55/1915330327 @github.com>