ChartBoost / chartboost-mediation-unity-sdk

Chartboost Mediation Unity SDK provides support for Unity based games to easily integrate Chartboost Mediation for Android & iOS platforms

https://www.chartboost.com/mediate

MIT License

8 stars 3 forks source link

[HB-6642] Update Usage of Getting Screen Scale on iOS17+ #195

Closed bwised closed 12 months ago

bwised commented 12 months ago

Title

HB-6642 Replace usage of UIScreen.Main.Scale on native IOS bridge since it is marked deprecated

Description

UIScreen.main is deprecated. Mimic'd the Swift implementation in the iOS native SDK as closely as possible from https://github.com/ChartBoost/ios-helium-sdk/pull/1314.

Type of change

[ ] Bug fix (fixes an issue)
[ ] New feature (adds functionality)
[x] Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

github-actions[bot] commented 12 months ago

Test Results

1 tests ±0 1 :heavy_check_mark: ±0 0s :stopwatch: ±0s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit 620ea539. ± Comparison against base commit 4aff2437.