ChartBoost / chartboost-mediation-unity-sdk

Chartboost Mediation Unity SDK provides support for Unity based games to easily integrate Chartboost Mediation for Android & iOS platforms

https://www.chartboost.com/mediate

MIT License

8 stars 3 forks source link

[HB-6714] Fix CI Job for Checks Not Performed When Workflow Pushes a Commit #214

Closed kushG closed 11 months ago

kushG commented 11 months ago

Title

HB-6714 Fix CI Job for Checks Not Performed When Workflow Pushes a Commit

Description

Fixes the CI job that was not going through checks since we were using secrets.GITHUB_TOKEN to avoid recursive workflow trigger on push.

We no longer use secrets.GITHUB_TOKEN now and instead use a repository variable that is used as a "base case" to prevent recursive workflow

Type of change

[x] Bug fix (fixes an issue)
[ ] New feature (adds functionality)
[ ] Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

github-actions[bot] commented 11 months ago

Test Results

5 tests ±0 5 :heavy_check_mark: ±0 0s :stopwatch: ±0s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit 77b160dd. ± Comparison against base commit bdeffa39.

:recycle: This comment has been updated with latest results.