search

ChartBoost / ruff-action

A GitHub Action for Ruff
Apache License 2.0
128 stars 20 forks source link

adding changed-files: 'true' fails #27

Open ingjulioreyes opened 3 months ago

ingjulioreyes commented 3 months ago

Hi,

I'm using this config:

- name: Ruff lint
  continue-on-error: true
  uses: chartboost/ruff-action@e18ae971ccee1b2d7bbef113930f00c670b78da4 #https://github.com/ChartBoost/ruff-action/releases/tag/v1
    with:
      src: './scripts'
      args: 'format --check'
      changed-files: 'true'

But when running the action shows:

Warning: Unexpected input(s) 'changed-files', valid inputs are ['args', 'src', 'version']
Run chartboost/ruff-action@e18ae971ccee1b2d7bbef113930f00c670b78da4
  with:
    src: ./scripts
    args: format --check
    changed-files: true
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.14/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.14/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.14/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.14/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.14/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.14/x64/lib

Any advice on how to proceed? Thanks!

brucearctor commented 3 months ago

Looks like v1/release hasn't been updated. I'd look at updating the hash to a more recent version.

ingjulioreyes commented 3 months ago

Yeah, I just changed to the latest commit hash and it works.

This one: https://github.com/ChartBoost/ruff-action/commit/491342200cdd1cf4d5132a30ddc546b3b5bc531b

uses: chartboost/ruff-action@491342200cdd1cf4d5132a30ddc546b3b5bc531b

VICIWUOHA commented 2 months ago

Still keeping an eye on this for when it'll stop warning.

simon-bal commented 4 weeks ago

WIll this be fixed in the near-future in a released version?

DavidJFelix commented 2 weeks ago

Relevant changes: https://github.com/astral-sh/ruff-action/pull/4 also take a look at the new repo.